Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix piezo model #295

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Fix piezo model #295

merged 3 commits into from
Oct 28, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Oct 28, 2021

The latest version of Fast API does not support tuples with exact values (e.g. Tuple[int, int, int]) within pydantic models. This is due to OpenAPI specifications. It looks like this will get supported at some point, but this is a patch fix for now simply changing Tuple -> List in the model.

@munrojm munrojm added the release:patch Patch updates label Oct 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #295 (b3e728e) into main (b7a886c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files          47       47           
  Lines        2477     2477           
=======================================
  Hits         2209     2209           
  Misses        268      268           
Impacted Files Coverage Δ
emmet-core/emmet/core/polar.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5261d17...b3e728e. Read the comment docs.

@munrojm munrojm merged commit edfbd01 into materialsproject:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants