Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include charge_density in summary has_props #305

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Nov 8, 2021

No description provided.

@munrojm munrojm added the release:patch Patch updates label Nov 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #305 (42e9e5e) into main (210db56) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   90.63%   90.64%   +0.01%     
==========================================
  Files          47       47              
  Lines        2435     2438       +3     
==========================================
+ Hits         2207     2210       +3     
  Misses        228      228              
Impacted Files Coverage Δ
emmet-core/emmet/core/summary.py 88.39% <ø> (ø)
emmet-builders/emmet/builders/materials/summary.py 96.42% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dccd37...42e9e5e. Read the comment docs.

@munrojm munrojm merged commit 51563a0 into main Nov 8, 2021
@munrojm munrojm deleted the chgcar_to_summary branch November 8, 2021 21:17
@mkhorton
Copy link
Member

mkhorton commented Nov 8, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants