-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elasticity doc and builder #326
Conversation
@munrojm I plan to have the PR merged soon. Can you first approve running workflows? Also, it seems you have already added some elasticity doc; now I just overwrite it by this PR. We can probably discuss more offline. In addition, there are some TODOs that I need to check with you. |
Hi @mjwen, no problem. Happy to meet and make this a priority. |
@munrojm ready for review! There are 3 to 4 TODOs in |
@munrojm good to go. |
… elastic stability
All looks good to me. Once the tests are passing, I will merge. |
Codecov Report
@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 98.06% 97.77% -0.29%
==========================================
Files 109 112 +3
Lines 23205 23653 +448
==========================================
+ Hits 22755 23127 +372
- Misses 450 526 +76
Continue to review full report at Codecov.
|
Thanks again for all your work on this @mjwen! I am going to go ahead and merge. |
Schema and builder for elastic tensors and derived properties.
This PR regenerates the builders for elastic tensor calculations. It
creates schema for elastic tensors, compliance tensors, derived properties, as well as fitting data; the hope is to enable full provenance tracking and regeneration of the docs.
ports three different elastic tensor fitting methods from atomate, which can be selected at the builder level
filter tasks by INCAR params and task completion time in causes multiple tasks are associated with the same material
TODO: more unit tests should be added