Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticity doc and builder #326

Merged
merged 67 commits into from
Jun 7, 2022
Merged

Elasticity doc and builder #326

merged 67 commits into from
Jun 7, 2022

Conversation

mjwen
Copy link
Member

@mjwen mjwen commented Jan 4, 2022

Schema and builder for elastic tensors and derived properties.

This PR regenerates the builders for elastic tensor calculations. It

  • creates schema for elastic tensors, compliance tensors, derived properties, as well as fitting data; the hope is to enable full provenance tracking and regeneration of the docs.

  • ports three different elastic tensor fitting methods from atomate, which can be selected at the builder level

  • filter tasks by INCAR params and task completion time in causes multiple tasks are associated with the same material

TODO: more unit tests should be added

@mjwen
Copy link
Member Author

mjwen commented Mar 29, 2022

@munrojm I plan to have the PR merged soon. Can you first approve running workflows? Also, it seems you have already added some elasticity doc; now I just overwrite it by this PR. We can probably discuss more offline. In addition, there are some TODOs that I need to check with you.

@munrojm
Copy link
Member

munrojm commented Mar 29, 2022

Hi @mjwen, no problem. Happy to meet and make this a priority.

@mjwen
Copy link
Member Author

mjwen commented May 31, 2022

@munrojm ready for review!

There are 3 to 4 TODOs in builders/materials/elasticity.py and builders/vasp/materials.py, which we may want to discuss more.

@mjwen mjwen changed the title [WIP] Elasticity doc and builder Elasticity doc and builder Jun 2, 2022
@mjwen
Copy link
Member Author

mjwen commented Jun 2, 2022

@munrojm good to go.

@munrojm
Copy link
Member

munrojm commented Jun 6, 2022

All looks good to me. Once the tests are passing, I will merge.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #326 (a5f6b36) into main (0459457) will decrease coverage by 0.28%.
The diff coverage is 84.85%.

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   98.06%   97.77%   -0.29%     
==========================================
  Files         109      112       +3     
  Lines       23205    23653     +448     
==========================================
+ Hits        22755    23127     +372     
- Misses        450      526      +76     
Impacted Files Coverage Δ
...et-builders/emmet/builders/materials/elasticity.py 81.62% <81.62%> (ø)
emmet-core/emmet/core/elasticity.py 85.45% <85.38%> (ø)
emmet-builders/emmet/builders/vasp/materials.py 91.47% <93.33%> (-0.04%) ⬇️
emmet-core/emmet/core/common.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/math.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/vasp/material.py 96.15% <100.00%> (ø)
emmet-core/emmet/core/vasp/task_valid.py 100.00% <100.00%> (ø)
emmet-api/emmet/api/routes/electrodes/utils.py 93.54% <0.00%> (-6.46%) ⬇️
...api/emmet/api/routes/electrodes/query_operators.py 92.53% <0.00%> (-5.80%) ⬇️
emmet-api/emmet/api/routes/materials/utils.py 90.62% <0.00%> (-2.82%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588a3e2...a5f6b36. Read the comment docs.

@munrojm
Copy link
Member

munrojm commented Jun 7, 2022

Thanks again for all your work on this @mjwen! I am going to go ahead and merge.

@munrojm munrojm merged commit 6237f32 into materialsproject:main Jun 7, 2022
@mjwen mjwen mentioned this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants