Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chemsys, electrode, provenance, and robocrys changes #336

Merged
merged 9 commits into from
Jan 13, 2022
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jan 13, 2022

  • Fix battery formula generation in electrodes
  • Add composition summary list data in electrodes doc + builder
  • Change electrode query operators to support composition summary data
  • Search endpoints added to provenance and robocrys
  • Chemsys can now take in a list

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #336 (0b8b527) into main (2fd7997) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   91.73%   91.96%   +0.22%     
==========================================
  Files          84       85       +1     
  Lines        3655     3759     +104     
==========================================
+ Hits         3353     3457     +104     
  Misses        302      302              
Impacted Files Coverage Δ
...-api/emmet/api/routes/materials/query_operators.py 95.57% <ø> (ø)
...api/emmet/api/routes/elasticity/query_operators.py 100.00% <100.00%> (ø)
...api/emmet/api/routes/electrodes/query_operators.py 100.00% <100.00%> (ø)
emmet-api/emmet/api/routes/electrodes/utils.py 100.00% <100.00%> (ø)
emmet-api/emmet/api/routes/materials/utils.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/electrode.py 97.69% <100.00%> (+0.57%) ⬆️
emmet-core/emmet/core/math.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/polar.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd7997...0b8b527. Read the comment docs.

@munrojm munrojm merged commit 8122a76 into main Jan 13, 2022
@munrojm munrojm deleted the electrode_updates branch March 25, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants