Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core model and operator improvements, overhaul of pagination params #368

Merged
merged 29 commits into from
Apr 14, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Feb 10, 2022

This PR includes:

  • Identify and include group info in header for CloudFlare rate limit settings
  • List input supported for formula, working ion
  • Ensure proper units in all document model descriptions -- Done in docs
  • Endpoint information pointed to in summary fields -- Done in docs
  • Rename limit and skip params

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #368 (58a9829) into main (cfa03ca) will decrease coverage by 0.08%.
The diff coverage is 91.61%.

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   92.27%   92.19%   -0.09%     
==========================================
  Files          85       85              
  Lines        4546     4574      +28     
==========================================
+ Hits         4195     4217      +22     
- Misses        351      357       +6     
Impacted Files Coverage Δ
...api/emmet/api/routes/elasticity/query_operators.py 100.00% <ø> (ø)
emmet-core/emmet/core/base.py 100.00% <ø> (ø)
emmet-core/emmet/core/symmetry.py 93.75% <ø> (ø)
emmet-core/emmet/core/thermo.py 94.64% <ø> (ø)
emmet-core/emmet/core/xas.py 33.64% <36.36%> (ø)
...api/emmet/api/routes/electrodes/query_operators.py 98.33% <75.00%> (-1.67%) ⬇️
...-api/emmet/api/routes/molecules/query_operators.py 97.36% <80.00%> (-2.64%) ⬇️
emmet-api/emmet/api/routes/materials/utils.py 93.54% <88.88%> (-6.46%) ⬇️
emmet-api/emmet/api/routes/electrodes/utils.py 100.00% <100.00%> (ø)
...-api/emmet/api/routes/materials/query_operators.py 92.43% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d1fa9...58a9829. Read the comment docs.

@munrojm munrojm changed the title Core model and operator improvements Core model and operator improvements, overhaul of pagination params Apr 9, 2022
@munrojm munrojm merged commit df1f94f into main Apr 14, 2022
@munrojm munrojm deleted the core_model_improvements branch May 11, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set header to allow for load-testing via continuous integration to bypass CF rate limiting
2 participants