Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trajectory endpoint fix #382

Merged
merged 6 commits into from
Mar 25, 2022
Merged

Trajectory endpoint fix #382

merged 6 commits into from
Mar 25, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Mar 25, 2022

Trajectory objects from endpoint now have correct number of ionic steps

@munrojm munrojm added the release:patch Patch updates label Mar 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #382 (7c6380f) into main (3f46d1f) will increase coverage by 9.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
+ Coverage   82.92%   92.35%   +9.43%     
==========================================
  Files          62       85      +23     
  Lines        3063     4528    +1465     
==========================================
+ Hits         2540     4182    +1642     
+ Misses        523      346     -177     
Impacted Files Coverage Δ
emmet-core/emmet/core/oxidation_states.py 91.11% <ø> (ø)
emmet-api/emmet/api/routes/tasks/utils.py 100.00% <100.00%> (ø)
...builders/emmet/builders/materials/piezoelectric.py 91.89% <0.00%> (ø)
...met-builders/emmet/builders/materials/magnetism.py 96.55% <0.00%> (ø)
emmet-builders/emmet/builders/__init__.py 100.00% <0.00%> (ø)
emmet-core/emmet/core/provenance.py 94.31% <0.00%> (ø)
emmet-builders/emmet/builders/vasp/materials.py 91.50% <0.00%> (ø)
emmet-core/emmet/core/structure_group.py 95.32% <0.00%> (ø)
emmet-core/emmet/core/robocrys.py 100.00% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f46d1f...7c6380f. Read the comment docs.

@munrojm munrojm merged commit 292ccc6 into main Mar 25, 2022
@munrojm munrojm deleted the bugfix/correct_trajectory_steps branch April 7, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants