[WIP] Adding Mobility Screening Builders #393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a demonstration
Another demo
New migration_graph builder from electrodes
Removed materials store and wi_entry as builder inputs. get wi from electrode doc.
changed field labels to match convention and added docstrings
added self to get_migration_graph call
added docstring and necessary import statements. reformatted with black. also added test file for this builder
Fixed some formatting issues per last PR
Changed docstring format in methods
Add first draft of MigrationGraphBuilder
update task_doc query to account for integer "material_ids". change "mg" field to "migration_graph"
updated test file to test a wider batch of battery_ids
Revisions to MigrationGraphBuilder
using different hop_cutoff (combo method, limited to 1.1*max primitive unit cell length)
new migration_graph_2 builder with "combo" hop cutoff method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developing new builders that assist with screening materials for solid state mobility.