Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single atom fix #413

Merged
merged 2 commits into from
May 5, 2022
Merged

Conversation

espottesmith
Copy link
Contributor

Production build died because the single_atom.json file was not included in the package version of emmet. To avoid that in the laziest way possible, I've just put all of the data included in that JSON in a dictionary.

@munrojm munrojm added the release:patch Patch updates label May 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #413 (3adbddf) into main (6a527eb) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         109      109           
  Lines       23194    23194           
=======================================
  Hits        22749    22749           
  Misses        445      445           
Impacted Files Coverage Δ
emmet-builders/emmet/builders/materials/chemenv.py 100.00% <ø> (ø)
emmet-builders/emmet/builders/qchem/molecules.py 96.55% <0.00%> (ø)
...mmet-builders/emmet/builders/molecules/orbitals.py 98.82% <100.00%> (ø)
emmet-builders/emmet/builders/molecules/thermo.py 96.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e01618...3adbddf. Read the comment docs.

@munrojm munrojm merged commit 6b0a0dc into materialsproject:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants