Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take absolute value for magnetic moment validation #415

Merged
merged 1 commit into from
May 11, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented May 11, 2022

Ensures the absolute value of the magnetic moments is taken when doing validation

@munrojm munrojm added the release:patch Patch updates label May 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #415 (b1ba786) into main (9369cd2) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         109      109           
  Lines       23194    23194           
=======================================
  Hits        22749    22749           
  Misses        445      445           
Impacted Files Coverage Δ
emmet-core/emmet/core/vasp/validation.py 82.17% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a46227...b1ba786. Read the comment docs.

@munrojm munrojm merged commit 8631a87 into main May 11, 2022
@munrojm munrojm deleted the bugfix/mag_validation branch May 11, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants