Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tags to be None in validation #419

Merged
merged 3 commits into from
May 20, 2022
Merged

Allow tags to be None in validation #419

merged 3 commits into from
May 20, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented May 19, 2022

Allow task documents to be validated with or without tags

@munrojm munrojm added the release:patch Patch updates label May 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #419 (113a6e9) into main (795ed51) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   98.06%   97.87%   -0.19%     
==========================================
  Files         109       87      -22     
  Lines       23205    21461    -1744     
==========================================
- Hits        22755    21005    -1750     
- Misses        450      456       +6     
Impacted Files Coverage Δ
emmet-core/emmet/core/vasp/task_valid.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/utils.py 57.69% <0.00%> (-32.70%) ⬇️
emmet-core/emmet/core/oxidation_states.py 73.33% <0.00%> (-17.78%) ⬇️
emmet-core/emmet/core/qchem/molecule.py 80.18% <0.00%> (-16.99%) ⬇️
emmet-core/emmet/core/summary.py 80.29% <0.00%> (-10.22%) ⬇️
emmet-core/emmet/core/settings.py 88.13% <0.00%> (-8.48%) ⬇️
emmet-core/emmet/core/molecules/atomic.py 93.15% <0.00%> (-2.74%) ⬇️
emmet-core/emmet/core/mpid.py 94.44% <0.00%> (-1.86%) ⬇️
emmet-core/emmet/core/molecules/bonds.py 80.72% <0.00%> (-1.81%) ⬇️
emmet-core/emmet/core/electronic_structure.py 94.54% <0.00%> (-0.61%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d6954...113a6e9. Read the comment docs.

@munrojm munrojm merged commit 62eaa05 into main May 20, 2022
@munrojm munrojm deleted the bugfix/default_tags_none branch May 20, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants