Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling deformation tasks in materials builder #453

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jul 11, 2022

If a deformed task is found that does not have any transmuter data, MaterialsBuilder now excludes the task from the build process and continues instead of throwing an error.

@munrojm munrojm added the release:patch Patch updates label Jul 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #453 (2f7ffae) into main (e319a85) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
- Coverage   97.67%   97.67%   -0.01%     
==========================================
  Files         114      114              
  Lines       23835    23838       +3     
==========================================
+ Hits        23282    23283       +1     
- Misses        553      555       +2     
Impacted Files Coverage Δ
emmet-builders/emmet/builders/vasp/materials.py 95.38% <33.33%> (-0.74%) ⬇️
emmet-core/emmet/core/vasp/validation.py 70.31% <66.66%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25be9a...2f7ffae. Read the comment docs.

@munrojm munrojm merged commit 2dde9c6 into main Jul 12, 2022
@munrojm munrojm deleted the bugfix/materials_deformation branch July 12, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants