Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StructureGroupDoc Pulling Correct Material Id #500

Merged

Conversation

kim-jiyoon
Copy link
Contributor

I updated the StructureGroupDoc and relevant tests to get the correct material id from the data field instead of from the entry id.

@munrojm @acrutt

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #500 (b328c3e) into main (f84f446) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         116      116           
  Lines       24120    24120           
=======================================
  Hits        23532    23532           
  Misses        588      588           
Impacted Files Coverage Δ
emmet-core/emmet/core/structure_group.py 93.27% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@munrojm munrojm added the release:patch Patch updates label Aug 12, 2022
@kim-jiyoon kim-jiyoon changed the title [WIP] StructureGroupDoc Pulling Correct Material Id StructureGroupDoc Pulling Correct Material Id Aug 12, 2022
@munrojm munrojm merged commit 694dddf into materialsproject:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants