Remove get_summary_dict() from InsertionElectrodeDoc #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 97.54% 97.53% -0.01%
==========================================
Files 116 116
Lines 24126 24135 +9
==========================================
+ Hits 23533 23541 +8
- Misses 593 594 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
acrutt
changed the title
|
@munrojm I think this is ready to merge! Let me know if any edits are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InsertionElectrodeDoc.from_entries()relied on pymatgen'sInsertionElectrode.get_summary_dict(). With the most recent changes to the thermo builder (where material_ids are no longer stored as entry.entry_id), this method was no longer reliable for correctly extracting and storing material_ids.InsertionElectrodeDoc.get_elec_doc()was added to replaceget_summary_dict()to resolve this bug. Overall this change will also allow other document features to be customized based on Material Project specific needs moving forward (independent of pymatgen).Minor clean-up to
InsertionElectrodeDoc.from_entries()was added to simplify this code.