Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external database IDs to summary #544

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Sep 23, 2022

No description provided.

@munrojm munrojm added the release:patch Patch updates label Sep 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Base: 76.39% // Head: 97.49% // Increases project coverage by +21.09% 🎉

Coverage data is based on head (8a921c7) compared to base (fc25c8f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #544       +/-   ##
===========================================
+ Coverage   76.39%   97.49%   +21.09%     
===========================================
  Files          65      116       +51     
  Lines        3716    24153    +20437     
===========================================
+ Hits         2839    23548    +20709     
+ Misses        877      605      -272     
Impacted Files Coverage Δ
emmet-core/emmet/core/summary.py 90.44% <100.00%> (+10.44%) ⬆️
emmet-core/emmet/core/molecules/vibration.py 86.66% <0.00%> (ø)
emmet-core/emmet/core/robocrys.py 93.10% <0.00%> (ø)
emmet-core/emmet/core/molecules/bonds.py 82.53% <0.00%> (ø)
...et-builders/emmet/builders/materials/dielectric.py 91.78% <0.00%> (ø)
emmet-core/emmet/core/qchem/molecule.py 97.16% <0.00%> (ø)
emmet-core/emmet/core/optimade.py 9.61% <0.00%> (ø)
emmet-core/emmet/core/qchem/calc_types/utils.py 93.24% <0.00%> (ø)
emmet-core/emmet/core/electrode.py 96.52% <0.00%> (ø)
...lders/emmet/builders/materials/oxidation_states.py 100.00% <0.00%> (ø)
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit 448a5ac into main Sep 23, 2022
@munrojm munrojm deleted the enhancement/icsd_to_summary branch September 23, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants