Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updates to magnetism, bond, mp_website builders, new bond_valence, mp_website_digest builders #64

Merged
merged 16 commits into from
Oct 1, 2018

Conversation

mkhorton
Copy link
Member

Marked as a [WIP] but these have been tested in Jupyter, and have partial/complete builds available.

I modified a few before making the PR to match house style/support incremental builds, so I may have introduced a bug hence the WIP, but I wanted to share before I take off for a few days ...

Have:

  • new bond valence builder
  • more magnetism metadata
  • digest builder (it's very basic, we probably want to discuss want to include though)
  • updates to bond builder

I have about a 2/3rds bond valence build, a full magnetism build, a sample digest build, and a huge bond build I could copy-build over if necessary. Most of these are quite fast apart from the bond build however.

@mkhorton mkhorton changed the title [WIP] Updates to magnetism, mp_website builders, new bond_valence, mp_website_digest builders [WIP] Updates to magnetism, bond, mp_website builders, new bond_valence, mp_website_digest builders Sep 13, 2018
@shyamd
Copy link
Contributor

shyamd commented Sep 14, 2018

Should i get rid of the WIP improvements to the mag builder PR?

@mkhorton
Copy link
Member Author

Yes, thanks — I just closed the other one, it’s all wrapped into this one.

@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@mkhorton
Copy link
Member Author

Think this is ready to merge once tests pass.

Some additional magnetism updates and bond statistics updates to come as a separate PR.

Have made a few minor edits to mp_website doc, no breaking changes.

@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Sep 30, 2018
@materialsproject materialsproject deleted a comment Oct 1, 2018
@materialsproject materialsproject deleted a comment Oct 1, 2018
@materialsproject materialsproject deleted a comment Oct 1, 2018
@materialsproject materialsproject deleted a comment Oct 1, 2018
@materialsproject materialsproject deleted a comment Oct 1, 2018
@materialsproject materialsproject deleted a comment Oct 1, 2018
@materialsproject materialsproject deleted a comment Oct 1, 2018
@mkhorton
Copy link
Member Author

mkhorton commented Oct 1, 2018

Merging, note bumped requirements.

@shyamd if there are any issues with changes to mp_website builder ping me + I'll fix asap, but all should be fine (tests pass....though I'm not sure we have mp_website tests specifically?), changes here: https://github.com/materialsproject/emmet/pull/64/files#diff-95824fcda1e1730ae54d52377edf7aad

@mkhorton mkhorton merged commit ee99da2 into master Oct 1, 2018
@mkhorton mkhorton deleted the mkhorton-builder-updates-1 branch October 1, 2018 20:33
utf referenced this pull request in utf/emmet May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants