-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Updates to magnetism, bond, mp_website builders, new bond_valence, mp_website_digest builders #64
Conversation
Should i get rid of the WIP improvements to the mag builder PR? |
Yes, thanks — I just closed the other one, it’s all wrapped into this one. |
Think this is ready to merge once tests pass. Some additional magnetism updates and bond statistics updates to come as a separate PR. Have made a few minor edits to mp_website doc, no breaking changes. |
Merging, note bumped requirements. @shyamd if there are any issues with changes to mp_website builder ping me + I'll fix asap, but all should be fine (tests pass....though I'm not sure we have mp_website tests specifically?), changes here: https://github.com/materialsproject/emmet/pull/64/files#diff-95824fcda1e1730ae54d52377edf7aad |
Marked as a [WIP] but these have been tested in Jupyter, and have partial/complete builds available.
I modified a few before making the PR to match house style/support incremental builds, so I may have introduced a bug hence the WIP, but I wanted to share before I take off for a few days ...
Have:
I have about a 2/3rds bond valence build, a full magnetism build, a sample digest build, and a huge bond build I could copy-build over if necessary. Most of these are quite fast apart from the bond build however.