Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils to static #673

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Utils to static #673

merged 2 commits into from
Mar 8, 2023

Conversation

hmlli
Copy link
Contributor

@hmlli hmlli commented Mar 8, 2023

turn the utils function in MigrationGraphDoc into a static method, so that the MigrationGraphDoc object doesnt have to be initiated to use this method. Cleaner for use case of pulling data from db.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (27727cd) 91.50% compared to head (541420c) 91.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #673   +/-   ##
=======================================
  Coverage   91.50%   91.50%           
=======================================
  Files         144      144           
  Lines       10660    10658    -2     
=======================================
- Hits         9754     9753    -1     
+ Misses        906      905    -1     
Impacted Files Coverage Δ
emmet-core/emmet/core/mobility/migrationgraph.py 94.52% <100.00%> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hmlli
Copy link
Contributor Author

hmlli commented Mar 8, 2023

@munrojm Hi Jason! just a small change in a utils function within MigrationGraphDoc. Basically in the usage case, the function is almost never used with the instance initiated, so I changed it to a static method. Thanks!

@munrojm munrojm added the release:patch Patch updates label Mar 8, 2023
@munrojm
Copy link
Member

munrojm commented Mar 8, 2023

Sounds good! Thanks @hmlli.

@munrojm munrojm merged commit 229a1b1 into materialsproject:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants