-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded MPcule API #674
Expanded MPcule API #674
Conversation
…through molecule world)
…ing tests pass in emmet-core (including remaking JSON files for summary)
… names and instead create utility function to define a solvent string
…th LevelOfTheory with pre-defined solvents)
…agate to property documents
Reminder: need to regenerate "builder_XXX_set.json" test files once builders are all done
…ode to ensure long-term fixity of graph hashes.
… actually be used
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 91.50% 90.98% -0.53%
==========================================
Files 144 147 +3
Lines 10658 10898 +240
==========================================
+ Hits 9753 9915 +162
- Misses 905 983 +78
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Hey @munrojm looks like tests are passing, but maybe I'm not hitting enough lines in my tests. Do you want me to bulk up testing before merge? Also kind of confused how I could drop the number of files being tested by that much. I certainly didn't delete any tests... |
The main purpose of this PR is to expand the MPcules API, adding endpoints for all relevant collections (not just "mpcules_summary").
In addition, there are some smaller improvements:
Work still needs to be done to make the API more useful and user-friendly. This will require adding new fields to the MPcules data model. For expediency, this is being pushed off to another PR. Also note that I'm still planning on adding some features to pymatgen, particularly for the parsing of additional properties (MOLDEN input, Raman spectra, etc.), construction and visualization of molecular optimization trajectories, etc.
Contributor Checklist