Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_parse_additional_json ignore FW.json(.gz) #864

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Oct 17, 2023

Ignore FW.json(.gz) so jobflow doesn't try to parse prev_vasp_dir OutputReferences from it.

Reason
This was causing atomate2 MP workflows (see materialsproject/atomate2#504) to fail with

ValueError: Could not resolve reference 7f5a7f14-464c-4a5b-85f9-8d11b595be3b not in store or cache

if a FW.json.gz was present in the job's output directory.

@janosh janosh added Core Any updates for Emmet-Core fix Bug fix ecosystem Concerning the larger MP ecosystem labels Oct 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8184d2d) 91.34% compared to head (9c41d8e) 89.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
- Coverage   91.34%   89.66%   -1.68%     
==========================================
  Files         138      108      -30     
  Lines       12749     9603    -3146     
==========================================
- Hits        11646     8611    -3035     
+ Misses       1103      992     -111     
Files Coverage Δ
emmet-core/emmet/core/tasks.py 87.23% <100.00%> (ø)

... and 47 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janosh janosh merged commit 361214e into main Oct 17, 2023
@janosh janosh deleted the fix-fw-json-uuid-resolve-ref branch October 17, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Any updates for Emmet-Core ecosystem Concerning the larger MP ecosystem fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants