Add new POTCAR validation to VASP validation plus tests #892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on PR #874, rewrote
_potcar_hash_check
inemmet.core.vasp.validation
to use the new POTCARsummary_stats
method in pymatgen. This method is less brittle than the older md5 hashing scheme.Also updated
emmet.builders.vasp.task_validator
to use the_summary_stats
attribute of thePotcarSingle
class rather than the md5 hash in creating thepotcar_hash
field.Also added two tests:
tests/vasp/test_vasp.py
emmet.core.vasp.calculation.PotcarSpec
to ensure that thesummary_stats
field is read