Replace emmet.core.utils.ValueEnum with std lib enum.StrEnum
#917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValueEnum causes JSON serialization bug in pydantic model json.dump(atomate2_phonon_doc, json_file, cls=MontyEncoder)
janosh
added
Core
|
I have no issues with using a backport package for now. |
|
thanks @Andrew-S-Rosen, good to know. probably still makes sense to define a class StrEnum(str, Enum)to enforce string values certain enums in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case I missed something, @munrojm was there a reason not to use
enum.StrEnum?I was seeing JSON serialization errors with the
atomate2PhononMaker'spydanticmodel which don't occur withenum.StrEnum.Update
Didn't realize
StrEnumis 3.11+ only. We could use a backport package like https://github.com/irgeek/StrEnum.