Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion here:
materialsproject/jobflow#519
Added support for ULID: Universally Unique Lexicographically Sortable Identifier
The idea is the UUIDs are random and they cannot be sorted for aggregate document creation.
Since atomate2 will call some
emmet.core
documents directly we might not always have a chance to parse the task docs and assign MPIDs to everyone.This PR does the following:
self.parts
used for sorting are(ULID_ID, 0)
which should enough to help sort the documents.StructureGroup
to allow for ULID comparison.