Enhancement/open data store #893
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
==========================================
+ Coverage 88.16% 88.32% +0.16%
==========================================
Files 45 46 +1
Lines 3633 3760 +127
==========================================
+ Hits 3203 3321 +118
- Misses 430 439 +9 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
|
|
||
| def test_eq(memstore, s3store): | ||
| assert s3store == s3store |
Check warning
Code scanning / CodeQL
Comparison of identical values
| conn.create_bucket(Bucket="bucket1") | ||
| index = MemoryStore("index", key=1) | ||
| with pytest.raises(AssertionError, match=r"Since we are.*"): | ||
| store = OpenDataStore(index=index, bucket="bucket1", s3_workers=4, key=1) |
Check warning
Code scanning / CodeQL
Variable defined multiple times
| with mock_s3(): | ||
| tic = datetime(2018, 4, 12, 16) | ||
| tic2 = datetime.utcnow() | ||
| conn = boto3.client("s3") |
Check warning
Code scanning / CodeQL
Variable defined multiple times
|
|
||
|
|
||
| def test_index_eq(memstore, s3indexstore): | ||
| assert s3indexstore == s3indexstore |
Check warning
Code scanning / CodeQL
Comparison of identical values
|
@kbuma just went through this in detail. Everything is looking fantastic. I like the structure, and don't really have any specific comments other than to get your input on making the type of compression more configurable for the user. I'm thinking there may be some value in having the compression/decompression callables and header passed in the init, but with the same gzip defaults. Don't have a strong opinion though, so happy to merge whenever you feel good. |
|
@munrojm I'd like to hold off on making the compression more configurable unless there's an existing use case for it. If there is one let's discuss and add the feature. Otherwise, I'm good to merge. |
Summary
Major changes:
Checklist
ruff. (For guidance in fixing rule violates, see rule list)mypy.