-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MongograntStore: make optional dependency, prepare for removal #950
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
==========================================
- Coverage 81.33% 81.25% -0.09%
==========================================
Files 46 46
Lines 3971 3974 +3
==========================================
- Hits 3230 3229 -1
- Misses 741 745 +4 ☔ View full report in Codecov by Sentry. |
Does this look OK to you @munrojm ? I agree with your comment that we should probably remove |
@munrojm I think this is good to go. In my local testing both warnings behave as expected. I'll probably merge later today unless you have objections.
|
Summary
As discussed in #928
mongogrant
to the optional dependency group[mongogrant]
requires
decorator toMongograntStore
MongograntStore
for deprecation