Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for SC locpot #181

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Cleanup for SC locpot #181

merged 2 commits into from
Apr 3, 2024

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented Mar 29, 2024

Summary

Small change to API for get_sc_locpot

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.39%. Comparing base (ed4cb1a) to head (4ba995d).
Report is 6 commits behind head on main.

Files Patch % Lines
pymatgen/analysis/defects/thermo.py 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   90.35%   90.39%   +0.03%     
==========================================
  Files          11       11              
  Lines        2116     2123       +7     
  Branches      407      411       +4     
==========================================
+ Hits         1912     1919       +7     
+ Misses        117      115       -2     
- Partials       87       89       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmmshn jmmshn merged commit 98c1022 into main Apr 3, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant