Plotting #67
Plotting #67
Conversation
for more information, see https://pre-commit.ci
Codecov ReportBase: 91.10% // Head: 91.24% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 91.10% 91.24% +0.14%
==========================================
Files 11 11
Lines 1663 1736 +73
Branches 280 298 +18
==========================================
+ Hits 1515 1584 +69
- Misses 84 85 +1
- Partials 64 67 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…is-defects into plotting # Conflicts: # pymatgen/analysis/defects/thermo.py
for more information, see https://pre-commit.ci
|
@nwinner can you add a small test to cover the plotting? |
# Conflicts: # tests/test_thermo.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There's a small test now. Doesn't do much at the moment just makes sure no errors are raised basically |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…is-defects into plotting # Conflicts: # tests/test_thermo.py
for more information, see https://pre-commit.ci
…is-defects into plotting # Conflicts: # tests/test_thermo.py
for more information, see https://pre-commit.ci
|
@jmmshn Code coverage is not high enough for plotting. The things not covered by tests are actually covered, but because of the structure using a fixture instead of putting it directly in pytest, I don't think its picked up. If you want to be super strict about coverage, I can try some other ways to get it to recognize the coverage, otherwise it's probably ready to merge. |
|
no worries I was a bit busy writing this week. I will merge and release now. |
First pass at plotting functionality for new defects module.