Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voronoi Interstitial Generator #82

Merged
merged 10 commits into from
Dec 29, 2022
Merged

Voronoi Interstitial Generator #82

merged 10 commits into from
Dec 29, 2022

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented Dec 29, 2022

  • Added VoronoiInterstitialGenerator (similar to the old one but with various bug fixes)
  • Added multiplicity analysis for both existing InterstitialGenerators

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 90.74% // Head: 88.65% // Decreases project coverage by -2.08% ⚠️

Coverage data is based on head (c7da2c8) compared to base (85b4a88).
Patch coverage: 74.11% of modified lines in pull request are covered.

❗ Current head c7da2c8 differs from pull request most recent head f6e13a0. Consider uploading reports for the commit f6e13a0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   90.74%   88.65%   -2.09%     
==========================================
  Files          10       10              
  Lines        1469     1649     +180     
  Branches      234      283      +49     
==========================================
+ Hits         1333     1462     +129     
- Misses         77      120      +43     
- Partials       59       67       +8     
Impacted Files Coverage Δ
pymatgen/analysis/defects/utils.py 81.51% <68.58%> (-9.29%) ⬇️
pymatgen/analysis/defects/generators.py 95.54% <95.12%> (-0.37%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmmshn jmmshn merged commit aff3f20 into main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant