Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fixes #92

Merged
merged 4 commits into from
Jan 26, 2023
Merged

Minor Fixes #92

merged 4 commits into from
Jan 26, 2023

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented Jan 25, 2023

  • Allow different band indices to be used when calculating the elph_me
  • Don't used the distortion Q value as the dictionary key when storing wswq_files (floats should never be keys)

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 91.24% // Head: 91.15% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (7dac1f5) compared to base (6dc9001).
Patch coverage: 94.44% of modified lines in pull request are covered.

❗ Current head 7dac1f5 differs from pull request most recent head 9edb5da. Consider uploading reports for the commit 9edb5da to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   91.24%   91.15%   -0.09%     
==========================================
  Files          11       11              
  Lines        1736     1741       +5     
  Branches      298      303       +5     
==========================================
+ Hits         1584     1587       +3     
- Misses         85       88       +3     
+ Partials       67       66       -1     
Impacted Files Coverage Δ
pymatgen/analysis/defects/corrections/kumagai.py 94.44% <50.00%> (-0.16%) ⬇️
pymatgen/analysis/defects/ccd.py 85.12% <100.00%> (-0.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmmshn jmmshn merged commit ae48c75 into main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant