-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quasi-RRHO Thermochemistry Analysis Module #2028
Merged
Merged
Changes from 4 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
1762e15
Merge remote-tracking branch 'materialsproject/master' into readytoPR
dda14db
Linear molecules + units
0c1eed3
Merge remote-tracking branch 'materialsproject/master' into readytoPR
5217e93
Merge remote-tracking branch 'materialsproject/master' into readytoPR
2ff2dd1
Merge remote-tracking branch 'materialsproject/master' into readytoPR
9bf5f12
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ed81ba2
pylint debugging
83d6c41
Merge remote-tracking branch 'origin/readytoPR' into readytoPR
ba4edbe
Pylint fixing
793897a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 023ba48
black
76503f1
Merge remote-tracking branch 'origin/readytoPR' into readytoPR
80f2cc2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8e6e005
black 22.1.0
d08a1ca
Merge remote-tracking branch 'origin/readytoPR' into readytoPR
e8a6a81
QuasiRRHO: edits
rkingsbury dcb07ef
QuasiRRHO: update tests
rkingsbury 3437932
Merge remote-tracking branch 'materialsproject/master' into readytoPR
61c0e73
Merge pull request #1 from rkingsbury/qrrho
e8aeecd
Merge remote-tracking branch 'origin/readytoPR' into readytoPR
8e8e256
pre-commit auto-fixes
pre-commit-ci[bot] aef77b1
Incorporating comments
b0dcb5c
Merge remote-tracking branch 'materialsproject/master' into readytoPR
626ce1e
Merge remote-tracking branch 'origin/readytoPR' into readytoPR
b783de2
pre-commit
e6df7d9
Typos and doi
9420e6f
docs
54ed557
duecredit
0122859
pre-commit auto-fixes
pre-commit-ci[bot] b6fa300
Remove Concentration Correction
3e2a0cd
pre-commit auto-fixes
pre-commit-ci[bot] 5963413
Merge remote-tracking branch 'materialsproject/master' into readytoPR
e4cf61c
Changes to testing
f9ede66
pre-commit auto-fixes
pre-commit-ci[bot] e7cf9bf
Merge remote-tracking branch 'materialsproject/master' into readytoPR
06ad8e4
Merge remote-tracking branch 'origin/readytoPR' into readytoPR
9d2bcc9
add type hints and snake_case QuasiRRHO method names
janosh 9232e5d
rename single-letter module-scoped vars
janosh 02ac2c7
fix tests following method renaming
janosh f7d3fa7
add test_extreme_temperature_and_pressure() and test_get_avg_mom_iner…
janosh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add "Concentration correction is reference to a 1 M standard state."