Compress test files #3132
Open
Compress test files #3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per-file size reduction
negative numbers mean file size increased during compression |
|
@JaGeo @rkingsbury @arosen93 If anybody feels like chipping away at the above-mentioned issues, feel free to checkout the |
Thanks for the initiative @janosh ! I'll try to help out over the next few weeks. I'm honestly amazed at how much potential size reduction we can get this way. |
including fixes for all tests in test_structure.py
* fix test_exp_entries.py * fix test_computed_entries.py * Fix test_mixing_scheme.py * fix test_compatibility.py * lint
* Store site label in `site_properties` Revise implementation to fix test failures * Add test * pre-commit auto-fixes * rename single-letter vars, use snake_case * assert len(struct.site_properties["labels"]) == len(struct) and len(set(struct.site_properties["labels"])) == 4 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Janosh Riebesell <[email protected]>
…vent running tests on forks
if key in dict:
val = dict[key]
del dict[key]
to
val = dict.pop(key, None)
make all ParseError classes inherit from pymatgen.io.core.ParseError which is a SyntaxError subclass. allows for adding line numbers and filenames to errors
class SyntaxError(Exception):
msg: str
lineno: int | None
offset: int | None
text: str | None
filename: str | None
if sys.version_info >= (3, 10):
end_lineno: int | None
end_offset: int | None
* fix test_site_symmetries.py * fix analysis tests * Fix pymatgen/analysis tests
janosh
force-pushed
the
master
branch
2 times, most recently
from
3c23114 to
36e289c
Compare
4 tasks
janosh
force-pushed
the
master
branch
4 times, most recently
from
d725325 to
dca98be
Compare
janosh
force-pushed
the
master
branch
2 times, most recently
from
e3fbc67 to
41e6d99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2994.
Here's a 1st swing at compressing all test files. Takes the total size of the
test_filesfrom ~900 MB to 243 MB (73 % reduction) using simple Gzip compression as implemented in the Python standard library.Migration script
compress_test_files.pyThis PR will require a lot of tweaking, I'm sure, since the automated file path migration is naive and will invariably encounter both false positives and negatives. Also, not all tests support loading compressed files. We'll have to refactor those or revert to uncompressed.