Ion: handle dissolved gas formulas #3275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ion.reduced_formula
does not correctly handle dissolved gas molecules, such asO2
, for example:This PR modifies
Ion.get_reduced_formula_and_factor
to correctly report dissolved formulas of dissolved gases H2, N2, O2, F2, Cl2, and O3. It also updates the docstrings offormula
andreduced_formula
.Checklist
ruff
.mypy
.