Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hot Fix] Fix setuptools for pymatgen packaging #3934

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

DanielYang59
Copy link
Contributor

@DanielYang59 DanielYang59 commented Jul 18, 2024

Summary

Site note

To reliably recreate this issue, one might need to completely clear build cache (removing build/, dist/ and *.egg-info), otherwise you might find yourself (me for example) modifying the pyproject.toml file but find the wheel remains unchanged.

@DanielYang59
Copy link
Contributor Author

@shyuep @janosh @mkhorton Can you please review this hot fix? Thanks!

@DanielYang59 DanielYang59 changed the title Fix setuptools for pymatgen packaging [Hot Fix] Fix setuptools for pymatgen packaging Jul 18, 2024
@shyuep shyuep enabled auto-merge (squash) July 18, 2024 10:37
@shyuep shyuep merged commit 380d2f2 into materialsproject:master Jul 18, 2024
33 checks passed
@DanielYang59 DanielYang59 deleted the fix-package-setup branch July 18, 2024 11:43
@janosh janosh added fix Bug fix PRs install Installation issues pkg Package health and distribution related stuff labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PRs install Installation issues pkg Package health and distribution related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants