[Hot Fix] Fix setuptools
for pymatgen packaging
#3934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
setuptools
in not configured to include the completepymatgen
package (all subpackages are missing) after moving to the src layout.Turn offinclude-package-data
, which istrue
by default, meaningpackage-data
is not having any effect and all data files would be included into the package.pymatgen/tests/core/test_structure.py
Line 1771 in 0234182
Site note
To reliably recreate this issue, one might need to completely clear build cache (removing
build/
,dist/
and*.egg-info
), otherwise you might find yourself (me for example) modifying thepyproject.toml
file but find the wheel remains unchanged.