-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update M3GNet potential training notebook for the demonstrating of obtaining and using element offset #288
Conversation
Signed-off-by: Tsz Wai Ko <[email protected]>
…taining and using element offsets
WalkthroughRecent changes include enhancements to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TrainingNotebook
participant PotentialLightningModule
participant Model
User->>TrainingNotebook: Start training
TrainingNotebook->>PotentialLightningModule: Initialize with model, element_refs, lr, include_line_graph
PotentialLightningModule->>Model: Setup model with element_refs
Model-->>PotentialLightningModule: Model ready with element_refs
PotentialLightningModule-->>TrainingNotebook: Module initialized
TrainingNotebook-->>User: Training started successfully
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Summary
Update M3GNet potential training notebook for the demonstration of obtaining and using element offset
Checklist
ruff
.mypy
.duecredit
@due.dcite
decorators to reference relevant papers by DOI (example)Tip: Install
pre-commit
hooks to auto-check types and linting before every commit: