Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate monty.string.unicode2str #590

Closed
Andrew-S-Rosen opened this issue Oct 31, 2023 · 0 comments
Closed

Deprecate monty.string.unicode2str #590

Andrew-S-Rosen opened this issue Oct 31, 2023 · 0 comments

Comments

@Andrew-S-Rosen
Copy link
Contributor

It's only relevant for Python 2.
@Andrew-S-Rosen Andrew-S-Rosen changed the title Deprecate monty.string.unicode2str Deprecate monty.string.unicode2str Oct 31, 2023
shyuep pushed a commit that referenced this issue Oct 31, 2023
Remove defunct py2 code. Fixes #589 #590.
be5ec33
@shyuep shyuep closed this as completed Oct 31, 2023
janosh added a commit to materialsproject/pymatgen that referenced this issue Nov 3, 2023
@janosh
remove monty.string.unicode2str
a819991 
only needed in python 2 according to materialsvirtuallab/monty#590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shyuep @Andrew-S-Rosen