Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy pandas import to improve startup time #604

Closed
wants to merge 8 commits into from
Closed

Lazy pandas import to improve startup time #604

wants to merge 8 commits into from

Conversation

janosh
Copy link
Contributor

@janosh janosh commented Jan 23, 2024

Import times profiled and reported by @mturiansky in materialsproject/pymatgen#3563 (comment).

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (5d37679) 78.82% compared to head (127133c) 78.57%.

Files Patch % Lines
monty/json.py 68.75% 4 Missing and 1 partial ⚠️
monty/os/__init__.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
- Coverage   78.82%   78.57%   -0.26%     
==========================================
  Files          27       27              
  Lines        1393     1400       +7     
  Branches      297      297              
==========================================
+ Hits         1098     1100       +2     
- Misses        239      244       +5     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shyuep shyuep closed this Jan 23, 2024
@janosh janosh deleted the lazy-pandas-import branch January 23, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants