Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions #138

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Upgrade GitHub Actions #138

merged 1 commit into from
Feb 7, 2023

Conversation

@matham
Copy link
Owner

matham commented Feb 7, 2023

Can you rebase the PR on master (without the quick fail change)? It should pass successfully now.

About dependbot, I'm not a fan because in my experience it doesn't help when real version dependency is needed and instead just adds noise. These action versions technically don't to be bumped very often so setting up automatic dependbot just for that doesn't seem worth it.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 7, 2023

math.isclose(), but no cigar...

Could the extra performance of Python 3.11 be causing test_write_correct_frame_rate() to fail?

@matham matham merged commit d61343d into matham:master Feb 7, 2023
@matham
Copy link
Owner

matham commented Feb 7, 2023

heh

That shouldn't be it. It's a timestamping instability issue across different platforms. I've seen something previous, and is somewhat out of my control as it is dependent on ffmpeg. It probably can be fixed but I don't have the time to do that rn.

@cclauss cclauss deleted the patch-1 branch February 8, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants