Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Cython~=0.29.36, as ffpyplayer is incompatible with Cython>=3 (ATM) #152

Merged
merged 1 commit into from
Oct 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pythonapp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
run: python setup.py sdist --formats=gztar
- name: Install pip deps
run: |
python -m pip install --upgrade pip virtualenv wheel setuptools cython pytest
python -m pip install --upgrade pip virtualenv wheel setuptools cython~=0.29.36 pytest
- name: Make wheel
run: |
$env:SDL_ROOT=(get-item $env:SDL_ROOT).FullName
Expand Down
4 changes: 2 additions & 2 deletions doc/source/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Requirements

To compile ffpyplayer we need:

* Cython (``pip install --upgrade cython``).
* Cython (``pip install --upgrade cython~=0.29.36``).
* A c compiler e.g. gcc or MSVC.
* SDL2 or SDL1.2 (SDL1.2 is not recommended). See :ref:`compille` for how to get it.
* SDL2_mixer If wanting to play multiple audio files simultaneously (``USE_SDL2_MIXER`` must be set). See :ref:`compille` for how to get it.
Expand All @@ -41,7 +41,7 @@ Compiling ffpyplayer
* Download or compile FFMpeg and SDL2 as shown below and set the appropriate environment variables as needed.
* Install Cython with e.g.::

pip install --upgrade cython
pip install --upgrade cython~=0.29.36

* You can select the FFmpeg libraries to be used by defining values for CONFIG_XXX.
For example, CONFIG_AVFILTER=0 will disable inclusion of the FFmpeg avfilter libraries.
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[build-system]
requires = [
"setuptools", "wheel", "cython",
"setuptools", "wheel", "cython~=0.29.36",
]
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ def get_wheel_data():

setup_requires = []
if declare_cython:
setup_requires.append('cython')
setup_requires.append('cython~=0.29.36')

setup(name='ffpyplayer',
version=ffpyplayer.__version__,
Expand Down