Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API updates for confirm data step in CSV file import. #201

Closed
kgodey opened this issue Jun 7, 2021 · 1 comment · Fixed by #506
Closed

API updates for confirm data step in CSV file import. #201

kgodey opened this issue Jun 7, 2021 · 1 comment · Fixed by #506
Assignees
Labels
ready Ready for implementation work: backend Related to Python, Django, and simple SQL

Comments

@kgodey
Copy link
Contributor

kgodey commented Jun 7, 2021

Problem

Our design for file import cannot be handled by our existing APIs, specifically the data confirmation step.

Proposed solution

We need API updates that allow the user to:

Additional context

This issue involves a lot of changes to the architecture, so please write a technical spec on the wiki's Architecture section and get some feedback from @kgodey and @mathemancer before implementing this issue.

Please note that even though we have a table in the database at this point, we also have the actual data file stored on disk so we can access it if needed. We may want to do so while switching whether to use the first row as a header.

Blocked by #199, #200

@kgodey kgodey added type: enhancement work: backend Related to Python, Django, and simple SQL needs: unblocking Blocked by other work labels Jun 7, 2021
@kgodey kgodey added this to the Tables from File Import milestone Jun 7, 2021
@kgodey
Copy link
Contributor Author

kgodey commented Jun 28, 2021

@pavish's comment from #199 seems more appropriate to discuss here.

@kgodey @mathemancer The Column API makes perfect sense for maintaining REST API standards.

Based on the UX, the user will make multiple modifications (change names, types etc.,) and then hit save. To make it easier for clients and to avoid multiple updates, I believe we will need another endpoint that batches column updates? Thoughts?

I see that there is a ticket already #201 for the data confirmation page, but we haven't specified anything about batching these column updates anywhere.

@pavish I think it would be easiest to use the Column API from #199 to make modifications one column at a time as the user makes them (before they press save), because each of them is a distinct ALTER operation in the database with its own errors. That way, we can also show the user a preview of what their column looks like as the new type.

@kgodey kgodey added ready Ready for implementation and removed needs: unblocking Blocked by other work labels Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants