Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation for Number data types #248

Closed
13 tasks done
kgodey opened this issue Jun 14, 2021 · 3 comments
Closed
13 tasks done

Implementation for Number data types #248

kgodey opened this issue Jun 14, 2021 · 3 comments
Labels
pr-status: revision A PR awaiting follow-up work from its author after review

Comments

@kgodey kgodey added type: enhancement work: backend Related to Python, Django, and simple SQL ready Ready for implementation labels Jun 14, 2021
@kgodey kgodey added this to the 8. Initial Data Types milestone Jun 14, 2021
@mathemancer
Copy link
Contributor

I think we should split out a separate issue for NUMERIC types with arguments to support the "decimal" type with specified decimal points, etc.

I also think we should split out different issues for each underlying DB type:

  • REAL
  • DOUBLE PRECISION
  • SMALLINT
  • INTEGER
  • BIGINT

We should also have a separate issue for the percentage type¸ since that will require a custom type at the DB level, unlike the other types called for.

@kgodey kgodey added type: group ready Ready for implementation and removed ready Ready for implementation type: enhancement labels Jul 15, 2021
@kgodey
Copy link
Contributor Author

kgodey commented Jul 15, 2021

@mathemancer I've split up the issues. I asked you a question on #386.

@kgodey kgodey added work: product and removed work: backend Related to Python, Django, and simple SQL work: database labels Sep 13, 2021
@kgodey kgodey changed the title Backend/API implementation for Number data types Implementation for Number data types Sep 13, 2021
@mathemancer mathemancer mentioned this issue Dec 2, 2021
7 tasks
@kgodey kgodey added pr-status: revision A PR awaiting follow-up work from its author after review and removed ready Ready for implementation labels Mar 1, 2022
@kgodey
Copy link
Contributor Author

kgodey commented May 4, 2022

Closing this since all subtasks are done.

@kgodey kgodey closed this as completed May 4, 2022
Repository owner moved this from Waiting to Done in [NO LONGER USED] Mathesar work tracker May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review
Projects
No open projects
Development

No branches or pull requests

2 participants