-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement filtering options for Number types. #385
Comments
I suggest making sure we use inclusive Do we want to use symmetric between, or not? I.e., should |
I agree with using inclusive |
Since "between" is ambiguous about its symmetry and inclusiveness, maybe instead let's have the user create/compose two simpler filters where these properties are explicit: |
I definitely think we should have the former, but I'm not convinced that should be in lieu of the latter. Maybe initially, though. @kgodey I note that |
I'm fine with skipping |
I'm starting to draft a design. The idea at the moment is to formalize the filters on the |
Actually, since the filtering will target Mathesar types (correct?), which the |
Filtering should be for DB types. Mathesar types are only used to group DB types, they shouldn't have other functionality applied to them. |
Oh, what led me astray was that the Boolean filters are defined on Mathesar Types. It's not a big deal, I was going to rewrite them anyway. |
Yes, please rewrite them to fit, thanks! |
Problem
We need to ensure that records that include columns of all Number types support the following filters via API:
This involves:
/api/v0/databases/<id>/types/
endpoint to store available filters on this typebetween
needs 2 parameters,is empty
needs 0)Additional context
sqlalchemy-filters
to provide filtering. See: https://github.com/centerofci/sqlalchemy-filters.NUMERIC
data type in the backend. #377SMALLINT
data type in the backend. #378INTEGER
data type in the backend. #379BIGINT
data type in the backend. #380DECIMAL
data type in the backend. #381REAL
data type in the backend. #382DOUBLE PRECISION
data type in the backend. #383MATHESAR_TYPES.PERCENTAGE
type. #434The text was updated successfully, but these errors were encountered: