Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up
getLabel
props for a few components, with the following goals.Don't use a
labelKey
argument within thegetLabel
prop.Rationale: The consuming component has two ways of customizing the label. Either (a) via the
labelKey
prop, or (b) via thegetLabel
prop. When using (b), then (a) should be irrelevant. ThegetLabel
function signature is simpler when it does not concern itself withlabelKey
.Allow
getLabel
to return an instance ofComponentAndProps
.Make all
getLabel
props consistently use the typeLabelGetter<Option>
across all relevant components.Checklist
Update index.md
).master
branch of the repositoryDeveloper Certificate of Origin
Developer Certificate of Origin