-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix confusing "role" field on user edit form #4104
base: beta_user_docs
Are you sure you want to change the base?
Conversation
@ghislaineguerin you might like to read over this PR description as well, since this PR slightly modifies the UX here. Let me know if you have any concerns with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I have one comment on the help text.
@@ -24,6 +24,7 @@ | |||
"add_user": "Add User", | |||
"admin": "Admin", | |||
"admin_access": "Admin Access", | |||
"admin_user_checkbox_help": "Admin users have some additional privileges, but only for high-level Mathesar-specific operations like connecting databases and managing other users. A user's admin status does not affect their access to the data within the connected databases.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A user's admin status does not affect their access to the data within the connected databases.
This text might end up misleading the user. An admin can modify their own access (and the access of others) to connected databases. So, the admin status does affect the access to the data within the connected databases.
Fixes #4068
Checklist
Update index.md
).develop
branch of the repositoryDeveloper Certificate of Origin
Developer Certificate of Origin