Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing "role" field on user edit form #4104

Open
wants to merge 2 commits into
base: beta_user_docs
Choose a base branch
from

Conversation

seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Jan 3, 2025

⚠️ Stacked on #4031

Fixes #4068

Before After
image image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen added this to the v0.2.0 (beta release) milestone Jan 3, 2025
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Jan 3, 2025
@seancolsen
Copy link
Contributor Author

@ghislaineguerin you might like to read over this PR description as well, since this PR slightly modifies the UX here. Let me know if you have any concerns with this.

@seancolsen
Copy link
Contributor Author

@pavish note that this is stacked on #4031 which I don't expect to be merged soon. Please review this PR, but don't merge it yet.

Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I have one comment on the help text.

@@ -24,6 +24,7 @@
"add_user": "Add User",
"admin": "Admin",
"admin_access": "Admin Access",
"admin_user_checkbox_help": "Admin users have some additional privileges, but only for high-level Mathesar-specific operations like connecting databases and managing other users. A user's admin status does not affect their access to the data within the connected databases.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A user's admin status does not affect their access to the data within the connected databases.

This text might end up misleading the user. An admin can modify their own access (and the access of others) to connected databases. So, the admin status does affect the access to the data within the connected databases.

@pavish pavish assigned seancolsen and unassigned pavish Jan 6, 2025
@pavish pavish added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants