Add ability to change columns' data type

[asharonbaltazar]

Implements #498

⚠ Work in Progress ⚠

Many features aren't yet done and neither is the code quality final. This draft is to track feedback and discuss implementation ideas.

Changes

• Created a new component <CellHeader />
• Moved <Header /> and <CellHeader /> to their own folder & separated their styling from TableView.scss
• Created a new types Svelte store
• Added a types API call in the fetchTableDetails function in tableData.ts and stored in the types Svelte store

Screenshots

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the master branch of the repository
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[asharonbaltazar]

@kgodey Please review some of my code. None of it is final, and I'm familiarizing myself with the codebase with UI building for now. I'm open to suggestions & criticism.

I'm also unsure how to change the columns' data types. Is it done with a call to the backend? Many of the discussions are long and scattered, and I spend most of my time just reading them without much direction. I'd appreciate a pointer here.

P.S. If this is a way of getting open-source work done, then I have to say it's very clever 😄

[kgodey]

I'll defer code review to @pavish, our frontend developer.

Yes, you'll need to use backend APIs to get the list of types as well as change the data type. The relevant pull request and issue are linked in #498 under "additional context".

• Type mapping between Mathesar and database types #532 implements the types API that you use to pull in the list of types.
• Add Columns endpoint #303 implements the column API, which you use to change types. You can pass in db_types values from the types endpoint in a PATCH request to a column.

You can browse through all available APIs at http://localhost:8000/api/v0/. Real API documentation is on our to-do list, but we need to prioritize getting some features done first.

[pavish]

Still have to figure out a way to toggle isAdvancedOptionsOpen when the user clicks outside the dropdown to close it.

We can dispatch an outbound event 'onClose' from within the dropdown component. We could use that event to process callbacks as required.

[asharonbaltazar]

We can dispatch an outbound event 'onClose' from within the dropdown component. We could use that event to process callbacks as required.

I actually implemented a prop like that and called it beforeClose but decided against it for some reason