-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle deleting table constraints #760
Conversation
2c971b1
to
538c1a4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seancolsen I love the subtle animation and the simplicity of the confirmation view.
I do have a few comments which I'd like to be addressed before we merge this PR.
mathesar_ui/src/sections/table-view/constraints/TableConstraint.svelte
Outdated
Show resolved
Hide resolved
mathesar_ui/src/sections/table-view/constraints/TableConstraint.svelte
Outdated
Show resolved
Hide resolved
An additional minor comment: When all constraints are deleted, only an empty modal with a title is shown. It would be better if we showed additional text mentioning that there are no constraints available. |
|
- Use `api` property within `ConstraintsDataStore` to hold api methods. - Show loading spinner only when constaints data is empty and loading.
@pavish Ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seancolsen The changes look good to me!
Nice work on this @seancolsen. |
Fixes #328
Before
After
User can delete table constraints through the "Table Constraints" modal.
(The slow frame rate of the gif doesn't really do justice to the CSS transitions, which I think look really nice in the browser.)
Notes
After dropping the constraint, the constraints store is re-fetched.
I added a couple new UI components:
Spinner
, so that we can write<Spinner />
instead of<Icon data={faSpinner} spin={true}/>
. (One fewer import!)Seesaw
(open to suggestions for a better name here) which switches between a "left" and "right" content using a slide transition.Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin