Jenkinsfile is source code

[peterlynch]

Jenkinsfile is intended to be checked into SCM. As such it should contain a license just like any other source file.

https://www.jenkins.io/doc/book/pipeline/jenkinsfile/

[hazendaz]

@mathieucarbou Few questions here. Testing in at least windows, Jenkinsfile will just throw a warning because it has no file extension. What style would it have? I presume those must be both figured out with standard code and not seeing how here.

[peterlynch]

My bad. I meant to follow up with pr adding slash star style format for jenkinsfile...

…

On Mon., May 3, 2021, 4:35 p.m. Jeremy Landis, ***@***.***> wrote: @mathieucarbou <https://github.com/mathieucarbou> Few questions here. Testing in at least windows, Jenkinsfile will just throw a warning because it has no file extension. What style would it have? I presume those must be both figured out with standard code and not seeing how here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#198 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABPK3P45WPTB4SRD775TK3TL33IFANCNFSM43DNMREQ> .

[mathieucarbou]

@peterlynch could you please send a PR asap to rollback the support for Jenkins files ? I will be able to release a fix and it will give time for proper support and testing. I think the issue comes from the fact that license style detection is done based on the extension and this file has no extension.
I think that the code returning the extension of a file perhaps could return the file name if no extension is set so that we can correctly determine header styles based on either extension or fixed file names.

Thanks for the report @hazendaz 👍

[peterlynch]

I can try to do this in the next few days

…

On Mon., May 3, 2021, 7:32 p.m. Mathieu Carbou, ***@***.***> wrote: @peterlynch <https://github.com/peterlynch> could you please send a PR asap to rollback the support for Jenkins files ? I will be able to release a fix and it will give time for proper support and testing. I think the issue comes from the fact that license style detection is done based on the extension and this file has no extension. I think that the code returning the extension of a file perhaps could return the file name if no extension is set so that we can correctly determine header styles based on either extension or fixed file names. Thanks for the report @hazendaz <https://github.com/hazendaz> 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#198 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABPK3NBELSJDHKEUXJZZLDTL4P7BANCNFSM43DNMREQ> .

[mathieucarbou]

@hazendaz : meanwhile, you could easily fix that by adding the Jenkins files in your list of excluded files I think. This will revert to the old behaviour at least (not perfect but will ignore those files).

Here is the commit FYI: 33c7cd5

[hazendaz]

@mathieucarbou Yes, thanks. I did exactly that. Not a huge deal for now. Will be nice to see ability to license such files as we have a number of them that don't fit nicely currently. Appreciate it!