Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TeX input] autoload does not load the color extension [was: \definecolor does not work] #307

Closed
physikerwelt opened this issue Mar 22, 2017 · 5 comments
Closed

[TeX input] autoload does not load the color extension [was: \definecolor does not work] #307

physikerwelt opened this issue Mar 22, 2017 · 5 comments
Labels
Accepted Fixed
Milestone
Next steps

Comments

@physikerwelt
Copy link
Contributor

I'm not sure if that's a MathJax or a Mathjax-node bug. But it seems that \definecolor has stopped working

see
#306
for a test case
@pkra
Copy link
Contributor

pkra commented Mar 22, 2017

This is due to #175. MathJax-node was loading the autoload extension which in turn loads the color extension. Since color is the only extension loaded by autoload that changes core behavior (the others only add features), this was deemed inconsistent with core MathJax.

You can manually load the color extension to re-enable it.

Your test exposes a drawback of the resolution of #175: specifying the autoload extension manually now fails to load the color extension.

It might be best after all if we didn't load autoload in mathjax-node but the specific extensions.

@pkra pkra changed the title \definecolor does not work [TeX input] autoload does not load the color extension [was: \definecolor does not work] Mar 22, 2017
@pkra pkra added the Accepted label Mar 22, 2017
@physikerwelt
Copy link
Contributor Author

You can manually load the color extension to re-enable it.

Yes! Thank worked. @pkra thank you for your outstanding support.

From my point of wie the issue can be closed.

@pkra
Copy link
Contributor

pkra commented Mar 22, 2017

Glad to hear it worked.

I'd like to leave it open to check whether we want to revisit the autoloading behavior.

@physikerwelt
Copy link
Contributor Author

It's not a new bug though
wikimedia@241703c

physikerwelt added a commit to physikerwelt/mathoid-server that referenced this issue Mar 22, 2017
@physikerwelt
\definecolor is unknown
16f6c6b 
Explicitly load color module.

See also
mathjax/MathJax-node#307

Change-Id: I0c051ceff40afbc2a63cd66ad8f8a14358daeb2a
@pkra
Copy link
Contributor

pkra commented Apr 3, 2017

Simple fix: expand the check at https://github.com/mathjax/MathJax-node/blob/master/lib/main.js#L425 to autoload-all.js

@pkra pkra added this to the Next steps milestone Apr 3, 2017
pkra pushed a commit that referenced this issue Apr 3, 2017
@physikerwelt @pkra
[test] add test for #307
d42daf3
pkra added a commit that referenced this issue Apr 3, 2017
@pkra
[main] user configuration with autload-all should enable color extension
be019fc 
Fixes #307
@pkra pkra mentioned this issue Apr 3, 2017
Merged
pkra added a commit that referenced this issue Apr 3, 2017
@pkra
Fix #307 (#314)
8f18918 
* [test] add test for #307

* [main] user configuration with autload-all should enable color extension
Fixes #307
@pkra pkra added the Fixed label Apr 3, 2017
@pkra pkra closed this as completed in 8efd937 Apr 5, 2017
physikerwelt added a commit to physikerwelt/mathoid-server that referenced this issue Aug 8, 2017
@physikerwelt
Update to MathJax-node 1.0
06b60a6 
Adjust the mathoid package to be compatible with
MathJax-node 1.0

Change-Id: I6da6df392f1d5d36d52ac36aa607d2766c758aac

Calculate the mathoid style attribute

* This was formerly done in mathjax-node

Change-Id: I61d0da4e6bb715e8ad5e09c37bf192df4cb21804

Add speech support

Adapted from
https://github.com/pkra/mathjax-node-sre/blob/master/lib/main.js

Change-Id: I594e6d01e7a9e099c0a90a7416075e6af6e9dbbf

Fix: Config MathJax only once

Remove accidentally added second MathJax config call.

Change-Id: I73229ca286af3d54f39157c883f10705c1a0b6ed

Investigate differences in test results

* Temporarily disable verbose output and rely on the IDE capabilities

Change-Id: I0cbf5a5da383443bd47fdbd8b2be02129ff89b1e

Add option to expose enriched pmml

Expose the enriched pmml as well

Change-Id: I9a35103307f4003636912053f0bd40105bd52a2b

Fix order of expected and actual output

The order of actual and expected output was swapped.

Change-Id: I443e17016821735922a1b037d52c0b7001a54dc5

\definecolor is unknown

Explicitly load color module.

See also
mathjax/MathJax-node#307

Change-Id: I0c051ceff40afbc2a63cd66ad8f8a14358daeb2a

Do not use semantic annotations for simple tests

Change-Id: I59bba1bd9045bfb3f010a9ef07e3d2efa084c5ec

Re add png support

Reused some code from mathoid-mathjax-node version 0.6.6

Change-Id: If7f8a02255ec1a0f963e8b62741de0b5030bcb9c

Update dependencies

Change-Id: Ic085ad4fab6723a32cfd16d1b9336943be4fe552

Update reference images

Change-Id: I55a032c4960a26009e675e082d766e05aa1615f9

Improve testing infrastructure

ignore XML inherent differences

Change-Id: Ib887d170b7b3bb003177db192f92b7cd7db01914

Fix dimensions in test cases

Change-Id: Ia839f75e0a5004ece105df40b0e64d54376af11c

Store testdata in a seperate file

Change-Id: I0a61aa8bcf725691834f973a98888e3329704353

Deduplicate test code

Change-Id: I44a635802e9075bae634b999b6811b747c5e618a

Add script to adjust test

* Add more options to skip tests
* Update test data

Change-Id: I9fe1e0e5fe0585edc4f85d6a3747e3f3c748083f
physikerwelt added a commit to physikerwelt/mathoid-server that referenced this issue Aug 8, 2017
@physikerwelt
Update to MathJax-node 1.0
89b1933 
Adjust the mathoid package to be compatible with
MathJax-node 1.0

Change-Id: I6da6df392f1d5d36d52ac36aa607d2766c758aac

Calculate the mathoid style attribute

* This was formerly done in mathjax-node

Change-Id: I61d0da4e6bb715e8ad5e09c37bf192df4cb21804

Add speech support

Adapted from
https://github.com/pkra/mathjax-node-sre/blob/master/lib/main.js

Change-Id: I594e6d01e7a9e099c0a90a7416075e6af6e9dbbf

Fix: Config MathJax only once

Remove accidentally added second MathJax config call.

Change-Id: I73229ca286af3d54f39157c883f10705c1a0b6ed

Investigate differences in test results

* Temporarily disable verbose output and rely on the IDE capabilities

Change-Id: I0cbf5a5da383443bd47fdbd8b2be02129ff89b1e

Add option to expose enriched pmml

Expose the enriched pmml as well

Change-Id: I9a35103307f4003636912053f0bd40105bd52a2b

Fix order of expected and actual output

The order of actual and expected output was swapped.

Change-Id: I443e17016821735922a1b037d52c0b7001a54dc5

\definecolor is unknown

Explicitly load color module.

See also
mathjax/MathJax-node#307

Change-Id: I0c051ceff40afbc2a63cd66ad8f8a14358daeb2a

Do not use semantic annotations for simple tests

Change-Id: I59bba1bd9045bfb3f010a9ef07e3d2efa084c5ec

Re add png support

Reused some code from mathoid-mathjax-node version 0.6.6

Change-Id: If7f8a02255ec1a0f963e8b62741de0b5030bcb9c

Update dependencies

Change-Id: Ic085ad4fab6723a32cfd16d1b9336943be4fe552

Update reference images

Change-Id: I55a032c4960a26009e675e082d766e05aa1615f9

Improve testing infrastructure

ignore XML inherent differences

Change-Id: Ib887d170b7b3bb003177db192f92b7cd7db01914

Fix dimensions in test cases

Change-Id: Ia839f75e0a5004ece105df40b0e64d54376af11c

Store testdata in a seperate file

Change-Id: I0a61aa8bcf725691834f973a98888e3329704353

Deduplicate test code

Change-Id: I44a635802e9075bae634b999b6811b747c5e618a

Add script to adjust test

* Add more options to skip tests
* Update test data

Change-Id: I9fe1e0e5fe0585edc4f85d6a3747e3f3c748083f

Support for get requests

Change-Id: If70f6756b69fa32a01018c46a594712eea2abc31
physikerwelt added a commit to physikerwelt/mathoid-server that referenced this issue Aug 8, 2017
@physikerwelt
Update to MathJax-node 1.0
d294ecb 
Adjust the mathoid package to be compatible with
MathJax-node 1.0

Change-Id: I6da6df392f1d5d36d52ac36aa607d2766c758aac

Calculate the mathoid style attribute

* This was formerly done in mathjax-node

Change-Id: I61d0da4e6bb715e8ad5e09c37bf192df4cb21804

Add speech support

Adapted from
https://github.com/pkra/mathjax-node-sre/blob/master/lib/main.js

Change-Id: I594e6d01e7a9e099c0a90a7416075e6af6e9dbbf

Fix: Config MathJax only once

Remove accidentally added second MathJax config call.

Change-Id: I73229ca286af3d54f39157c883f10705c1a0b6ed

Investigate differences in test results

* Temporarily disable verbose output and rely on the IDE capabilities

Change-Id: I0cbf5a5da383443bd47fdbd8b2be02129ff89b1e

Add option to expose enriched pmml

Expose the enriched pmml as well

Change-Id: I9a35103307f4003636912053f0bd40105bd52a2b

Fix order of expected and actual output

The order of actual and expected output was swapped.

Change-Id: I443e17016821735922a1b037d52c0b7001a54dc5

\definecolor is unknown

Explicitly load color module.

See also
mathjax/MathJax-node#307

Change-Id: I0c051ceff40afbc2a63cd66ad8f8a14358daeb2a

Do not use semantic annotations for simple tests

Change-Id: I59bba1bd9045bfb3f010a9ef07e3d2efa084c5ec

Re add png support

Reused some code from mathoid-mathjax-node version 0.6.6

Change-Id: If7f8a02255ec1a0f963e8b62741de0b5030bcb9c

Update dependencies

Change-Id: Ic085ad4fab6723a32cfd16d1b9336943be4fe552

Update reference images

Change-Id: I55a032c4960a26009e675e082d766e05aa1615f9

Improve testing infrastructure

ignore XML inherent differences

Change-Id: Ib887d170b7b3bb003177db192f92b7cd7db01914

Fix dimensions in test cases

Change-Id: Ia839f75e0a5004ece105df40b0e64d54376af11c

Store testdata in a seperate file

Change-Id: I0a61aa8bcf725691834f973a98888e3329704353

Deduplicate test code

Change-Id: I44a635802e9075bae634b999b6811b747c5e618a

Add script to adjust test

* Add more options to skip tests
* Update test data

Support for get requests

Change-Id: If70f6756b69fa32a01018c46a594712eea2abc31

Change-Id: I9fe1e0e5fe0585edc4f85d6a3747e3f3c748083f
physikerwelt added a commit to physikerwelt/mathoid-server that referenced this issue Sep 6, 2017
@physikerwelt
WIP: Update to MathJax-node 1.0
fe43f79 
Adjust the mathoid package to be compatible with
MathJax-node 1.0

Calculate the mathoid style attribute

* This was formerly done in mathjax-node

Add speech support

Adapted from
https://github.com/pkra/mathjax-node-sre/blob/master/lib/main.js

Fix: Config MathJax only once

Remove accidentally added second MathJax config call.

Investigate differences in test results

* Temporarily disable verbose output and rely on the IDE capabilities

Add option to expose enriched pmml

Expose the enriched pmml as well

Fix order of expected and actual output

The order of actual and expected output was swapped.

\definecolor is unknown

Explicitly load color module.

See also
mathjax/MathJax-node#307

Do not use semantic annotations for simple tests

Re add png support

Reused some code from mathoid-mathjax-node version 0.6.6

Update dependencies

Update reference images

Improve testing infrastructure

ignore XML inherent differences

Fix dimensions in test cases

Store testdata in a seperate file

Deduplicate test code

Add script to adjust test

* Add more options to skip tests
* Update test data

Support for get requests

Bug: T172767 T155201
Change-Id: I9fe1e0e5fe0585edc4f85d6a3747e3f3c748083f
wmfgerrit pushed a commit to wikimedia/mediawiki-services-mathoid that referenced this issue Dec 19, 2017
@physikerwelt
Update to mathoid-mathjax-node 0.7
9a29d44 
* Adjust the mathoid package to be compatible with
  MathJax-node 1.0
* Calculate the mathoid style attribute
  which was formerly done in mathjax-node
* Add speech support adapted from
https://github.com/pkra/mathjax-node-sre/blob/master/lib/main.js
* Add option to expose enriched pmml
* Fix: order of expected and actual output
  The order of actual and expected output was swapped.
* Fix \definecolor is unknown
  Explicitly load color module. See also
  mathjax/MathJax-node#307
* Do not use semantic annotations for simple tests
* Update dependencies
* Update reference images
* Improve testing infrastructure
** ignore XML inherent differences
** improve test coverage 100% now for math related code
   i.e., lib/math.js, lib/render.js, routes/mathoid.js
** Fix: Dimensions in test cases
** Store testdata in a separate file
** Deduplicate test code
** Add script to adjust test
** Add more options to skip tests
* Support for get requests

Bug: T172767 T155201 T182316
Change-Id: I9fe1e0e5fe0585edc4f85d6a3747e3f3c748083f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Fixed
Projects
None yet
Milestone
Next steps
Development

No branches or pull requests
2 participants
@pkra @physikerwelt