Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsdom 10 compatibility #325

Closed
pkra opened this issue Apr 26, 2017 · 12 comments
Closed

jsdom 10 compatibility #325

pkra opened this issue Apr 26, 2017 · 12 comments
Labels
Milestone

Comments

@pkra
Copy link
Contributor

pkra commented Apr 26, 2017

jsdom 10 has changed its API.

It's also node 6+ only now.

@pkra
Copy link
Contributor Author

pkra commented Jan 4, 2018

@dpvc any chance you can look into this some time?

@dpvc
Copy link
Member

dpvc commented Jan 5, 2018

I've submitted a PR (#376) for this.

@dpvc
Copy link
Member

dpvc commented Jan 5, 2018

Looks like I need to fix some tests first. Sorry about that. I'm stuck on one with mglyph, since jsdom10 doesn't have the same flexibility about blocking the loading of items as version 9 did (you could allow scripts, but not images, and that can no longer be done, apparently). So I need to override more of MathJax to get mglyph to work properly with jsdom 10.

@pkra
Copy link
Contributor Author

pkra commented Jan 5, 2018

❤️ Thanks, Davide.

@pkra
Copy link
Contributor Author

pkra commented Jan 5, 2018

jsdom 10+ is node6+ only, so this should cause a major version jump, I think.

@pkra
Copy link
Contributor Author

pkra commented Jan 5, 2018

Oh, and travis needs to be restricted as node4 and 5 probably always fail.

@dpvc
Copy link
Member

dpvc commented Jan 5, 2018

Oh, and travis needs to be restricted as node4 and 5 probably always fail.

I don't know how travis is set up or configured. Can you point me to the right place to do that?

@pkra
Copy link
Contributor Author

pkra commented Jan 5, 2018

@dpvc
Copy link
Member

dpvc commented Jan 5, 2018

Thanks. I didn't see it because it was a dot file, and I didn't think to look for that (am used to .json files now)

@dpvc
Copy link
Member

dpvc commented Jan 5, 2018

OK, the tests all pass now. I think it is ready to go.

@dpvc
Copy link
Member

dpvc commented Jan 14, 2018

I've updated the version number and added the node6 engine dependency.

dpvc added a commit that referenced this issue Jan 14, 2018
Update to jsdom v10 interface.  Resolves issue #325.
@dpvc
Copy link
Member

dpvc commented Jan 14, 2018

==> Merged

@dpvc dpvc closed this as completed Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants