-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsdom 10 compatibility #325
Comments
@dpvc any chance you can look into this some time? |
I've submitted a PR (#376) for this. |
Looks like I need to fix some tests first. Sorry about that. I'm stuck on one with mglyph, since jsdom10 doesn't have the same flexibility about blocking the loading of items as version 9 did (you could allow scripts, but not images, and that can no longer be done, apparently). So I need to override more of MathJax to get mglyph to work properly with jsdom 10. |
❤️ Thanks, Davide. |
jsdom 10+ is node6+ only, so this should cause a major version jump, I think. |
Oh, and travis needs to be restricted as node4 and 5 probably always fail. |
I don't know how travis is set up or configured. Can you point me to the right place to do that? |
Thanks. I didn't see it because it was a dot file, and I didn't think to look for that (am used to .json files now) |
OK, the tests all pass now. I think it is ready to go. |
I've updated the version number and added the node6 engine dependency. |
Update to jsdom v10 interface. Resolves issue #325.
==> Merged |
jsdom 10 has changed its API.
It's also node 6+ only now.
The text was updated successfully, but these errors were encountered: