Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fontURL, support for reconfiguration #324

Closed
wants to merge 1 commit into from
Closed

Update fontURL, support for reconfiguration #324

wants to merge 1 commit into from

Conversation

pkra
Copy link
Contributor

@pkra pkra commented Apr 22, 2017

Fixes #323

@pkra
Copy link
Contributor Author

pkra commented Apr 22, 2017

I ended up going with a simple replace in the config() method. Not sure if there are objections to that.

@dpvc is there neeed for config()to be synchronized with the queue in general?

@dpvc
Copy link
Member

dpvc commented Apr 22, 2017

I don't think this change should be made. As mentioned in #323, just as with MathJax in the browser, configuration should be done before any typesetting occurs. There are many things that can't be reconfigured after typesetting begins; for example, you can't change the extensions after the initial typeset. I would not complicate the code (and add maintenance costs) for one feature while leaving all the others unaddressed. Is there really a use case for changing the font url between typesets? If so, you can always do mjAPI.start() again after the reconfiguration.

So I recommend not applying this PR.

@pkra
Copy link
Contributor Author

pkra commented Apr 22, 2017

See my comments on the issue.

@pkra
Copy link
Contributor Author

pkra commented May 2, 2017

Closing in favor of #326

@pkra pkra closed this May 2, 2017
@pkra pkra deleted the 323 branch May 2, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants