Skip to content

Commit

Permalink
Fix override comments as per review
Browse files Browse the repository at this point in the history
  • Loading branch information
dpvc committed Apr 6, 2022
1 parent a93fff1 commit 8ac3e24
Showing 1 changed file with 17 additions and 11 deletions.
28 changes: 17 additions & 11 deletions ts/output/common/Wrappers/mglyph.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

import {AnyWrapper, WrapperConstructor, Constructor} from '../Wrapper.js';
import {CommonTextNode} from './TextNode.js';
import {TextNode} from '../../../core/MmlTree/MmlNodes/TextNode.js';
import {TextNode} from '../../../core/MmlTree/MmlNode.js';
import {BBox} from '../../../util/BBox.js';

/*****************************************************************/
Expand All @@ -32,10 +32,16 @@ import {BBox} from '../../../util/BBox.js';
*/
export interface CommonMglyph extends AnyWrapper {
/**
* The image's width, height, and valign values converted to em's
* The image's width converted to em's
*/
width: number;
/**
* The image's height converted to em's
*/
height: number;
/*
* The image's valign values converted to em's
*/
valign: number;

/**
Expand All @@ -45,6 +51,10 @@ export interface CommonMglyph extends AnyWrapper {

/**
* Obtain the width, height, and valign.
* Note: Currently, the width and height must be specified explicitly, or they default to 1em
* Since loading the image may be asynchronous, it would require a restart.
* A future extension could implement this either by subclassing this object, or
* perhaps as a post-filter on the MathML input jax that adds the needed dimensions
*/
getParameters(): void;
}
Expand All @@ -65,20 +75,20 @@ export function CommonMglyphMixin<T extends WrapperConstructor>(Base: T): Mglyph
return class extends Base {

/**
* The image's width converted to em's
* @override
*/
public width: number;
/**
* The image's height converted to em's
* @override
*/
public height: number;
/**
* The image's valign values converted to em's
* @override
*/
public valign: number;

/**
* TextNode used for deprecated fontfamily/index use case
* @override
*/
public charWrapper: CommonTextNode;

Expand All @@ -92,11 +102,7 @@ export function CommonMglyphMixin<T extends WrapperConstructor>(Base: T): Mglyph
}

/**
* Obtain the width, height, and valign.
* Note: Currently, the width and height must be specified explicitly, or they default to 1em
* Since loading the image may be asynchronous, it would require a restart.
* A future extension could implement this either by subclassing this object, or
* perhaps as a post-filter on the MathML input jax that adds the needed dimensions
* @override
*/
public getParameters() {
const {width, height, valign, src, index} =
Expand Down

0 comments on commit 8ac3e24

Please sign in to comment.