Add ability to not show latex attributes, and reorganize settings menu #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
reviewed
Nov 20, 2023
| } | ||
| if (this.options.filterSRE) { | ||
| const keys = Object.keys(list).filter( | ||
| id => id.match(/^(?:data-semantic-.*?|role|aria-(?:level|posinset|setsize))$/) |
There was a problem hiding this comment.
What if we parse from MathML and some of these aria attributes are already in the incoming element?
(I suppose we would have overwritten them at this point anyway.)
There was a problem hiding this comment.
This filtering only occurs in the Show Math As or Copy Math As menus. Nothing is changed internally. This filtering is controlled by menu options, so the user can turn off the filtering in the case where retaining those values is desired. Does that put you more at ease?
There was a problem hiding this comment.
Note that this MmlVisitor is in the ts/ui/menu directory, not the one in ts/core/MmlTree, so it only affects the menu output.
dpvc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a menu option to remove the
data-latexanddata-latexItemattributes from the "Show Math As MathML" menu item, as these can get quite long, making it hard to see the MathML structure. We also reorganize the Math Settings submenu to push the MathML filters into an additional submenu level. Finally, we move the filtering of the SRE attributes into theMmlVisitorso the attributes are never added, rather than using a string replacement after the fact.