Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't insert <mi/> on right-aligned columns. (mathjax/MathJax#3089) #996

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Aug 25, 2023

This PR fixes a problem with the align and similar environments where if a second set of aligned columns are used, then initial minus signs (and other operators) will be treated as infix rather than prefix operators. This is because the additional empty mi nodes are being inserted for all columns but the first one. The fix proposed here is to not insert for right-justified columns (which will be the ones that start the second or later set of alignments). We can't use the column number itself, since align repeats after two columns, while eqnarray repeats after 3.

Resolves issue mathjax/MathJax#3089.

@dpvc dpvc requested a review from zorkow August 25, 2023 16:15
@dpvc dpvc added this to the v4.0 milestone Aug 25, 2023
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt.

@dpvc dpvc merged commit 04fb966 into develop Sep 15, 2023
@dpvc dpvc deleted the issue3089 branch September 15, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants